Fix regression in GhcSessionDeps#2380
Merged
mergify[bot] merged 4 commits intomasterfrom Nov 22, 2021
Merged
Conversation
jneira
approved these changes
Nov 21, 2021
Member
jneira
left a comment
jneira
left a comment
There was a problem hiding this comment.
many thanks for the quick fix, including regression tests
We cannot use GetModIfaceWithoutLinkable since the session might be reused later to load a module that needs linkables Note that this does not have any effects on performance, since GetModIfaceWithoutLinkable is just a synonym for GetModIface that removes the linkable Fixes #2379
pepeiborra
force-pushed
the
GetModWithoutLinkable
branch
from
d01a34e to
22c411f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use GetModIfaceWithoutLinkable since the session might be reused later to load a module that needs linkables
Note that this does not have any effects on performance, since GetModIfaceWithoutLinkable is just a synonym for GetModIface that removes the linkable
Fixes #2379